One of the annoying things with Jest is that while it enables you to run only a single test by using it.only
, it does not report this in any noticeable way. Thus you can end up in the same situation as we did, not running many tests without knowing it. (Oh yeah, if we only did review the code properly …).
This git pre-commit hook will fail when you introduce it.only
into the code:
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#!/bin/sh | |
# A git pre-commit hook that verifies that the change does not introduce | |
# the use of a Jest/Jasmine exclusive test via 'it.only(..)', which would | |
# prevent most other tests from being run without any clear indication thereof | |
# Redirect output to stderr. | |
exec 1>&2 | |
ADDED_IT_ONLY=$(git diff -U0 –cached -S"(\W|^)it\.only\s+?\(" –pickaxe-regex | egrep "(^\+.*it.only)|\+{3}") | |
if [ -n "$ADDED_IT_ONLY" ]; then | |
echo "PRE-COMIT CHECK FAILED: You have added calls to it.only(..) thus preventing other tests from running, please fix: $ADDED_IT_ONLY" | |
exit 1 | |
fi |
We are failing build when somebody left in tests ddescribe and iit 🙂 (we use karma with jasmine). This kind of Git pre-commit hook we are using for forcing prefix of commit messages with Jira Task ID.
Hello xpj, thank you for sharing your experience! Can you share your solution for failing build when ddescribe/iit is left in code?
We are using maven and we have checkVisualTests.sh script next to pom.xml. In pom.xml we configured exec-maven-plugin to run this shell script in the test phase. If this script returns exit code different from 1, build fails.
Script is simple, just few greps 🙂 But it works really good, only with one exception – multiline comment, but we have some rule, that even multiline comment should be same as single line (/* */ vs. //)
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gistfile1.sh
hosted with ❤ by GitHub
Correcting one thing – if script returns exit code different from 0, it fails build…